From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E2CB91384B4 for ; Sun, 6 Dec 2015 20:34:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7904721C0F8; Sun, 6 Dec 2015 20:34:33 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D07D921C0F6 for ; Sun, 6 Dec 2015 20:34:32 +0000 (UTC) Received: from [192.168.0.13] (ip174-67-193-3.oc.oc.cox.net [174.67.193.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 5B1A534074D; Sun, 6 Dec 2015 20:34:31 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH] Move QA_PREBUILT handling into src_install() To: gentoo-portage-dev@lists.gentoo.org References: <1449431847-26427-1-git-send-email-mgorny@gentoo.org> Cc: slyfox@gentoo.org, =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= From: Zac Medico X-Enigmail-Draft-Status: N1110 Message-ID: <56649BD0.2070607@gentoo.org> Date: Sun, 6 Dec 2015 12:34:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <1449431847-26427-1-git-send-email-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 40dd43f6-5f6a-4ccd-8cc3-82a88d4650a9 X-Archives-Hash: d78ad2e89674b3777b1ec68c6e7479af On 12/06/2015 11:57 AM, Michał Górny wrote: > Delay QA_PREBUILT handling until src_install(), to allow setting it in > phase function like pkg_setup(). This shouldn't cause any issues since > the resulting variables are not used before install. > --- > bin/ebuild.sh | 25 ------------------------- > bin/phase-functions.sh | 27 +++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 25 deletions(-) Looks good. -- Thanks, Zac