public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] SyncManager: redirect command stderr to stdout (bug 566132)
Date: Mon, 23 Nov 2015 08:46:34 -0800	[thread overview]
Message-ID: <565342EA.9060409@gentoo.org> (raw)
In-Reply-To: <5652ECEB.8050909@gentoo.org>

On 11/23/2015 02:39 AM, Alexander Berntsen wrote:
> Sorry for not being up to date what this does, but the bug complains
> specifically about GitHub mirrors, while the patch itself seems far
> more invasive. Is it the case that they should *never* go to STDERR?

Since the sync modules can call a variety of different commands, it's
hard to predict which ones will unnecessarily write to stderr. So, the
assumption here is that the process exit status is a more reliable
indicator for errors. For example, the python code in GitSync will write
an error message to stderr if the git process exits with non-zero status.
-- 
Thanks,
Zac


  reply	other threads:[~2015-11-23 16:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22 20:10 [gentoo-portage-dev] [PATCH] SyncManager: redirect command stderr to stdout (bug 566132) Zac Medico
2015-11-23 10:39 ` Alexander Berntsen
2015-11-23 16:46   ` Zac Medico [this message]
2015-11-24 11:34     ` Alexander Berntsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565342EA.9060409@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox