From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 786041384B4 for ; Wed, 18 Nov 2015 07:12:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B63D321C01F; Wed, 18 Nov 2015 07:12:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2B53321C01B for ; Wed, 18 Nov 2015 07:12:05 +0000 (UTC) Received: from [192.168.0.13] (ip174-67-193-3.oc.oc.cox.net [174.67.193.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 099C534092E; Wed, 18 Nov 2015 07:12:02 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare() To: gentoo-portage-dev@lists.gentoo.org References: <1447798842-5013-1-git-send-email-mgorny@gentoo.org> <22092.8754.979290.188470@a1i15.kph.uni-mainz.de> Cc: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= From: Zac Medico X-Enigmail-Draft-Status: N1110 Message-ID: <564C24C0.5040708@gentoo.org> Date: Tue, 17 Nov 2015 23:12:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <22092.8754.979290.188470@a1i15.kph.uni-mainz.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 9c82ac0e-f7b8-4a2e-ba0a-98eb27a31bfb X-Archives-Hash: ce1cf4ae2bb81253f8928d893ff2cda8 On 11/17/2015 11:01 PM, Ulrich Mueller wrote: >>>>>> On Tue, 17 Nov 2015, Michał Górny wrote: > >> __ebuild_phase src_prepare >> + >> + # keep path in eapply_user in sync! >> + if [[ ! -f ${T}/.portage_user_patches_applied ]]; then >> + die "eapply_user (or default) must be called in src_prepare()!" >> + fi >> + > > What happens if an ebuild calls eapply_user in src_unpack but not > in src_prepare? It will succeed in that case. If necessary, we can make eapply_user die if it's called during the wrong phase. > > Ulrich > -- Thanks, Zac