[gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

[gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Michał Górny]

Since thick Manifests can reference other files (ChangeLogs especially),
their generation should be run as the lask task done by egencache,
followed only by timestamp update.
---
 bin/egencache | 46 +++++++++++++++++++++++-----------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/bin/egencache b/bin/egencache
index 51d115a..e02c690 100755
--- a/bin/egencache
+++ b/bin/egencache
@@ -1095,29 +1095,6 @@ def egencache_main(args):
 		else:
 			ret.append(gen_cache.returncode)
 
-	if options.update_manifests:
-
-		cp_iter = None
-		if atoms:
-			cp_iter = iter(atoms)
-
-		event_loop = global_event_loop()
-		scheduler = ManifestScheduler(portdb, cp_iter=cp_iter,
-			gpg_cmd=gpg_cmd, gpg_vars=gpg_vars,
-			force_sign_key=force_sign_key,
-			max_jobs=options.jobs,
-			max_load=options.load_average,
-			event_loop=event_loop)
-
-		signum = run_main_scheduler(scheduler)
-		if signum is not None:
-			sys.exit(128 + signum)
-
-		if options.tolerant:
-			ret.append(os.EX_OK)
-		else:
-			ret.append(scheduler.returncode)
-
 	if options.update_pkg_desc_index:
 		if repo_config.writable:
 			writable_location = repo_config.location
@@ -1153,6 +1130,29 @@ def egencache_main(args):
 		gen_clogs.run()
 		ret.append(gen_clogs.returncode)
 
+	if options.update_manifests:
+
+		cp_iter = None
+		if atoms:
+			cp_iter = iter(atoms)
+
+		event_loop = global_event_loop()
+		scheduler = ManifestScheduler(portdb, cp_iter=cp_iter,
+			gpg_cmd=gpg_cmd, gpg_vars=gpg_vars,
+			force_sign_key=force_sign_key,
+			max_jobs=options.jobs,
+			max_load=options.load_average,
+			event_loop=event_loop)
+
+		signum = run_main_scheduler(scheduler)
+		if signum is not None:
+			sys.exit(128 + signum)
+
+		if options.tolerant:
+			ret.append(os.EX_OK)
+		else:
+			ret.append(scheduler.returncode)
+
 	if options.write_timestamp:
 		timestamp_path = os.path.join(repo_path, 'metadata', 'timestamp.chk')
 		try:
-- 
2.6.3

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Zac Medico]

On 11/12/2015 07:00 AM, Michał Górny wrote:
> Since thick Manifests can reference other files (ChangeLogs especially),
> their generation should be run as the lask task done by egencache,
> followed only by timestamp update.

GenPkgDescIndex needs to execute last, since it accesses the metadata.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Zac Medico]

On 11/12/2015 08:35 AM, Zac Medico wrote:
> On 11/12/2015 07:00 AM, Michał Górny wrote:
>> Since thick Manifests can reference other files (ChangeLogs especially),
>> their generation should be run as the lask task done by egencache,
>> followed only by timestamp update.
> 
> GenPkgDescIndex needs to execute last, since it accesses the metadata.
> 

Actually, the patch looks good.

I was confusing the manifest generation with the metadata generation.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Brian Dolbec]

On Thu, 12 Nov 2015 08:56:34 -0800
Zac Medico <zmedico@gentoo.org> wrote:

> On 11/12/2015 08:35 AM, Zac Medico wrote:
> > On 11/12/2015 07:00 AM, Michał Górny wrote:  
> >> Since thick Manifests can reference other files (ChangeLogs
> >> especially), their generation should be run as the lask task done
> >> by egencache, followed only by timestamp update.  
> > 
> > GenPkgDescIndex needs to execute last, since it accesses the
> > metadata. 
> 
> Actually, the patch looks good.
> 
> I was confusing the manifest generation with the metadata generation.

actually, looks like Robin made a bug for this after you submitted this
patch.

Can you edit the commit message, add the bug please. Bug 565626

-- 
Brian Dolbec <dolsen>

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 12/11/15 16:00, Michał Górny wrote:
> their generation should be run as the lask task done by egencache, 
> followed only by timestamp update.
Is "lask" supposed to be "last"? Also, "last except not last" is not
very good English. The word you seem to be looking for is
"penultimate". (Which would make the "only" redundant.)

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWRdTXAAoJENQqWdRUGk8BhEEQAO/lf5dmumM8OwqvoHFa3ncL
96ZARiqU6O/6j+jwB7s+hXrN/Ncc2Vjswu4qvbd//eXACrYZGVL2dxtZ8nukfmSP
tTOAngTkEA9SejTN/95KvQatN6Lnp5PI18xO5nKoI/RqpQRcUQVzS1NDLERY+U+O
vHZTXcQDvH7rhrKPWOp2ytQp0vMy/K8yPCp3KP1HEYY6170rN36M7pOuG6lcTk7o
o5iImoRhNsxS5rvJVc0SmTDYFlvrVsUDTZGAi7bzKzx0UADzUJGe+5Soz6hVsiBo
ah1fFZrFzelYVXJWnLqiyv6x/1iavf8SN4El68lD6pcqPr4BbkLUsFuZJTNzD2mY
TeEcXsMsJNnKsEwMIwCMeftvBQOCGoTkLLUh9k341Vapixb5EchLcQh0nG5l4UXU
V7jxglYdK54hKpJwdL+8rwBbd25vBKgtez+CkUjjFZKclF/KbEofmxnKHRjegGuu
vduCzKCY5jw7FLwPm94efp7LYrJ31VjLxQZ2C+C3DIZhvjPTfDxF+QHsme2TsrAW
fSybHRpvS8FJIRBam3C92M+jlj4BsCQad/YvLLTKHbTYZCFT97bC9eRcRBjbTXKp
3ZAF/Lz7wcuTAtBW7iRpo/+zNPHnKVISm4Xk7B58u9wGnvLNkJ2cV4ek6V1S64hT
8jtaf/3JR+ly//qlU7Gf
=1qO9
-----END PGP SIGNATURE-----

[gentoo-portage-dev] Re: [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Duncan]

Alexander Berntsen posted on Fri, 13 Nov 2015 13:17:28 +0100 as excerpted:

> On 12/11/15 16:00, Michał Górny wrote:
>> their generation should be run as the lask task done by egencache,
>> followed only by timestamp update.

> Is "lask" supposed to be "last"? Also, "last except not last" is not
> very good English. The word you seem to be looking for is "penultimate".
> (Which would make the "only" redundant.)

FWIW, while "penultimate" is unarguably correct, it's also in some 
regional dialects (US at least) rather rare and high-register, and is in 
fact a newish (within the year, and I'm nearing 50) addition to my own 
vocabulary.

The more common wording I'm far more familiar with, to the point of 
defining penultimate in terms of it in "the dictionary in my head", is 
"next-to-last".

[After checking...] Wictionary seems to agree, saying penultimate is 
British, in US it's considered formal/literary/scholarly, what I termed 
high register.  It defines penultimate in terms of next to last (or more 
archaic, last but one, tho in the US that's now seen as a Britishism too, 
see usage notes) as well.  (Meanwhile, I seriously can't picture /anyone/ 
using "propreantepenultimate" except as a joke!)

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman

Re: [gentoo-portage-dev] Re: [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Zac Medico]

On 11/13/2015 12:25 PM, Duncan wrote:
> Alexander Berntsen posted on Fri, 13 Nov 2015 13:17:28 +0100 as excerpted:
> 
>> On 12/11/15 16:00, Michał Górny wrote:
>>> their generation should be run as the lask task done by egencache,
>>> followed only by timestamp update.
> 
>> Is "lask" supposed to be "last"? Also, "last except not last" is not
>> very good English. The word you seem to be looking for is "penultimate".
>> (Which would make the "only" redundant.)
> 
> FWIW, while "penultimate" is unarguably correct, it's also in some 
> regional dialects (US at least) rather rare and high-register, and is in 
> fact a newish (within the year, and I'm nearing 50) addition to my own 
> vocabulary.
> 
> The more common wording I'm far more familiar with, to the point of 
> defining penultimate in terms of it in "the dictionary in my head", is 
> "next-to-last".
> 
> [After checking...] Wictionary seems to agree, saying penultimate is 
> British, in US it's considered formal/literary/scholarly, what I termed 
> high register.  It defines penultimate in terms of next to last (or more 
> archaic, last but one, tho in the US that's now seen as a Britishism too, 
> see usage notes) as well.  (Meanwhile, I seriously can't picture /anyone/ 
> using "propreantepenultimate" except as a joke!)
> 

There's a nice little discussion here:

http://english.stackexchange.com/questions/58959/is-penultimate-commonly-used

I haven't seen penultimate used much. "Next to last" is much more common
in my experience.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] Re: [PATCH] egencache: Delay updating Manifests until all other tasks complete

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

I'm not American -- and I would say/write penultimate. I don't very
much care though. Just pick one and fix the commit msg børk.
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWSbDgAAoJENQqWdRUGk8BTD4QAOb0lnu+iEYbclO3T1Kv1ljP
0ZfWQnfbGO5/ldE1GVioG+6SIuShISjuqy+nTpfBJuLNU8w7CCmItvda8JqlGRp8
h/DBWE8+D/TYEo2DlRU7vJsaF+BjYRAWyTXlYGOaPL42zjJ3Q08PEAu5aHLT3HXn
pEFLy+6lSJD7yxgff8+O6Zje1wh/PVBo5q4WBuDQ+Flrba6p6mvF1RJ/Q/OhZ+PS
4VZk3ay9b+oYNNogWw9hanR2Z2F75Mqw3zlUGLxvv53UbfWUCR+6DX2py5tUu1tD
mmNnMrX5xlRt0lsHRYf1/Dk1yDtIBUfe/oQzWl34X34tFIR+p6zcpMKkZOEzS0MU
JtR0o50Qv4kkQhMo65jH6orN0wPkQLLbWxligwnQG3Za3pJW4iTNL5T/c6chsyhX
aPxmbxuE58RTh7Nkxh8pGTfbTTLmHWc0No6+WrJAkOZMKobVv9RdWs3KXf0FVoBn
EDk3MGrU6bb9IOUDC+uOiRAGqkR8Hhgo2jzd+WWeXYwblFCS/b3nHf4QbNYDC4do
9/Uzi6+DcZBXDNmA0FYYgJXm3sl2g4wD7aqMHb2/b3Pttf+Mal7VqA8MdpC50I4O
1l+b7UjLOCxVVAd9LDFJDYM/2jDA4JUhBBGaicRVN/5x3ob/xpxNCjMPAMS0kIz1
/3K18JamWkmoCcTyOQ5m
=51Ii
-----END PGP SIGNATURE-----