From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-portage-dev+bounces-4997-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
by finch.gentoo.org (Postfix) with ESMTP id 7D331139737
for <garchives@archives.gentoo.org>; Tue, 11 Aug 2015 17:54:16 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 40B12141F3;
Tue, 11 Aug 2015 17:54:15 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id B5E0E141B8
for <gentoo-portage-dev@lists.gentoo.org>; Tue, 11 Aug 2015 17:54:14 +0000 (UTC)
Received: from [10.128.12.146] (unknown [100.42.98.196])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
(Authenticated sender: zmedico)
by smtp.gentoo.org (Postfix) with ESMTPSA id C0241340D6F
for <gentoo-portage-dev@lists.gentoo.org>; Tue, 11 Aug 2015 17:54:13 +0000 (UTC)
Subject: Re: [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in
cache entries
To: gentoo-portage-dev@lists.gentoo.org
References: <1439314687-31061-1-git-send-email-mgorny@gentoo.org>
From: Zac Medico <zmedico@gentoo.org>
Message-ID: <55CA36C2.3030008@gentoo.org>
Date: Tue, 11 Aug 2015 10:54:10 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
Thunderbird/38.1.0
Precedence: bulk
List-Post: <mailto:gentoo-portage-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-portage-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-portage-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-portage-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-portage-dev.gentoo.org>
X-BeenThere: gentoo-portage-dev@lists.gentoo.org
Reply-to: gentoo-portage-dev@lists.gentoo.org
MIME-Version: 1.0
In-Reply-To: <1439314687-31061-1-git-send-email-mgorny@gentoo.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Archives-Salt: ae655c51-6d78-4a5c-9e97-11d685be3db9
X-Archives-Hash: 4a5300e643b2669fb57dec0e7e10527a
On 08/11/2015 10:38 AM, Michał Górny wrote:
> Remove the code skipping EAPI=0 output in cache entries. There is really
> no reason to treat EAPI=0 specially here, and this makes the output more
> consistent.
> ---
> bin/egencache | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/bin/egencache b/bin/egencache
> index 6075ccf..5c00248 100755
> --- a/bin/egencache
> +++ b/bin/egencache
> @@ -297,8 +297,6 @@ class GenCache(object):
> # EAPI from _parse_eapi_ebuild_head, we don't write cache
> # entries for unsupported EAPIs.
> if metadata is not None and eapi_supported:
> - if metadata.get('EAPI') == '0':
> - del metadata['EAPI']
> for trg_cache in self._trg_caches:
> self._write_cache(trg_cache,
> cpv, repo_path, metadata, ebuild_hash)
>
LTGM.
--
Thanks,
Zac