public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries
Date: Tue, 11 Aug 2015 10:54:10 -0700	[thread overview]
Message-ID: <55CA36C2.3030008@gentoo.org> (raw)
In-Reply-To: <1439314687-31061-1-git-send-email-mgorny@gentoo.org>

On 08/11/2015 10:38 AM, Michał Górny wrote:
> Remove the code skipping EAPI=0 output in cache entries. There is really
> no reason to treat EAPI=0 specially here, and this makes the output more
> consistent.
> ---
>  bin/egencache | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/bin/egencache b/bin/egencache
> index 6075ccf..5c00248 100755
> --- a/bin/egencache
> +++ b/bin/egencache
> @@ -297,8 +297,6 @@ class GenCache(object):
>  		# EAPI from _parse_eapi_ebuild_head, we don't write cache
>  		# entries for unsupported EAPIs.
>  		if metadata is not None and eapi_supported:
> -			if metadata.get('EAPI') == '0':
> -				del metadata['EAPI']
>  			for trg_cache in self._trg_caches:
>  				self._write_cache(trg_cache,
>  					cpv, repo_path, metadata, ebuild_hash)
> 

LTGM.
-- 
Thanks,
Zac


  reply	other threads:[~2015-08-11 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 17:38 [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries Michał Górny
2015-08-11 17:54 ` Zac Medico [this message]
2015-08-11 19:53   ` Brian Dolbec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CA36C2.3030008@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox