From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 89572138CDB for ; Wed, 10 Jun 2015 18:54:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D7E51E08CA; Wed, 10 Jun 2015 18:54:49 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 67923E08C4 for ; Wed, 10 Jun 2015 18:54:49 +0000 (UTC) Received: from [10.128.12.146] (unknown [100.42.98.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 9C9C5340A9D for ; Wed, 10 Jun 2015 18:54:48 +0000 (UTC) Message-ID: <557887F6.1070100@gentoo.org> Date: Wed, 10 Jun 2015 11:54:46 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place References: <1381957406-21749-1-git-send-email-vapier@gentoo.org> <1433019576-24115-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1433019576-24115-1-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: 3c3485a5-3d98-4d54-ad35-fd616fd65a1d X-Archives-Hash: 656b35e3e30a182b8f2841978bb4168e On 05/30/2015 01:59 PM, Mike Frysinger wrote: > Rather than each module implementing its own shim around the various > methods for accessing extended attributes, start a dedicated module > that exports a consistent API. > --- > v4 > - merge in recent quickpkg changes > - add a XATTRS_WORKS symbol for easy testing > - use - with -m when matching all > > bin/quickpkg | 12 +- > bin/xattr-helper.py | 11 +- > pym/portage/dbapi/vartree.py | 10 +- > pym/portage/tests/util/test_xattr.py | 178 +++++++++++++++++++++++++++ > pym/portage/util/_xattr.py | 228 +++++++++++++++++++++++++++++++++++ > pym/portage/util/movefile.py | 100 ++++----------- > pym/portage/util/xattr.py | 20 --- > 7 files changed, 441 insertions(+), 118 deletions(-) > create mode 100644 pym/portage/tests/util/test_xattr.py > create mode 100644 pym/portage/util/_xattr.py > delete mode 100644 pym/portage/util/xattr.py > LGTM, except this one line is indented with spaces instead of tabs in vartree.py: > def tar_contents(contents, root, tar, protect=None, onProgress=None, > - xattr=False): > + xattrs=False): -- Thanks, Zac