From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 27501138CD0 for ; Sat, 30 May 2015 18:23:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6ACD4E0896; Sat, 30 May 2015 18:23:02 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DFCBFE0895 for ; Sat, 30 May 2015 18:23:01 +0000 (UTC) Received: from [192.168.0.13] (ip174-67-205-96.oc.oc.cox.net [174.67.205.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 5B90A340C5B for ; Sat, 30 May 2015 18:22:58 +0000 (UTC) Message-ID: <5569FFFF.8030504@gentoo.org> Date: Sat, 30 May 2015 11:22:55 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] install-qa-check.d: issue warnings for 32bit ELFs not using LFS References: <1432626293-22692-1-git-send-email-vapier@gentoo.org> <1432650278-31471-1-git-send-email-vapier@gentoo.org> <5564983E.20306@gentoo.org> <20150530143534.GE2101@vapier> In-Reply-To: <20150530143534.GE2101@vapier> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: b8d2180d-36b6-40d3-907e-d12970b6c9f4 X-Archives-Hash: f1cf9869776f44874da38823674ea32f On 05/30/2015 07:36 AM, Mike Frysinger wrote: > On 26 May 2015 08:58, Zac Medico wrote: >> On 05/26/2015 07:24 AM, Mike Frysinger wrote: >>> + # Only check on 32-bit systems. Filtering by $ARCH here isn't perfect, but >>> + # it should be good enough for our needs. >>> + case ${ARCH} in >>> + arm|mips|ppc|sh|x86) ;; >>> + *) return ;; >>> + esac >> >> Shouldn't we also enable this for 64-bit archs when multilib is enabled? > > yes, but i think we should start here first. getting multilib right is kind of > a pain. this should give us enough coverage i think to get people to start > filing bugs which implicitly covers multilib users. once the dust has settled, > we can look at expanding the multilib coverage. although that would really > require a python implementation, and the current install hooks logic implicitly > requires every file to be bash. > > to use your pkg-config example, it installs 32bit & 64bit ELFs into /usr/bin. > we can't scan all 32bit ELFs because it would incorrectly flag ILP32 ABIs like > x32 & n32. Our compute_multilib_category function has logic that could be used to separate and filter them: https://gitweb.gentoo.org/proj/portage.git/tree/pym/portage/dep/soname/multilib_category.py > ideally we'd scan the whole multilib dir, but that too runs into problems. > when /usr/lib is the path for both x86 multilib and non-multilib content (like > libexec stuff), we can't blindly scan & reject all ELFs in there. the previous > note about ILP32 applies here too. > > so if we're happy with this implementation, i'll start a thread on gentoo-dev so > people aren't caught by surprise, and we can merge this for the next release. > -mike > Okay, fine. -- Thanks, Zac