From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E6BEC138CA2 for ; Thu, 23 Apr 2015 01:43:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4B680E0856; Thu, 23 Apr 2015 01:43:30 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C8ADEE0854 for ; Thu, 23 Apr 2015 01:43:29 +0000 (UTC) Received: from [10.0.31.145] (unknown [100.42.98.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 03FEF340C9C; Thu, 23 Apr 2015 01:43:28 +0000 (UTC) Message-ID: <55384E3E.9020104@gentoo.org> Date: Wed, 22 Apr 2015 18:43:26 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: Bertrand Jacquin , gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK References: <1429559160-11646-1-git-send-email-bertrand@jacquin.bzh> <55358E1D.1070801@gentoo.org> <55359BBB.4080605@gentoo.org> <5cac28faa26324f08cc2bba6a17583e3@mail.meleeweb.net> In-Reply-To: <5cac28faa26324f08cc2bba6a17583e3@mail.meleeweb.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: 0452502a-8227-4c6f-8f26-f7b8240a76ca X-Archives-Hash: 0babe97f04ca102ff23e7e1d860e061f On 04/22/2015 04:44 PM, Bertrand Jacquin wrote: > On 21/04/2015 01:37, Zac Medico wrote: >> On 04/20/2015 05:31 PM, Bertrand Jacquin wrote: >>> On 21/04/2015 00:39, Zac Medico wrote: >>>> These are in the master branch now: >>>> >>>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911 >>>> >>>> >>>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=e74e2670e3f043608fced9847e54bdbb19f35169 >>>> >>>> >>> >>> Thanks for that :) >>> >>>> I modified the test as follows in order to ensure that it still works >>>> with shell globs: >>>> >>>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo >>>> "${root}"/${no_inst}) ]] ; then >>> >>> I do not really understand the use case here, do you have an example ? >>> >>> Cheers, >>> >> >> Well, I don't use INSTALL_MASK myself, so I don't have a real-world >> use-case for you. However, it's clear that the code will expand shell >> globs, so I preserved that behavior for compatibility. > > Sorry Zac, I was speaking about the $(echo ..), what does it bring to > use it here ? > > Cheers, > It's a way to check the result of check the result of shell glob expansion. The rm call that follows will be subject to identical expansion. -- Thanks, Zac