From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 263B4138CA2 for ; Tue, 21 Apr 2015 17:30:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 04950E08B8; Tue, 21 Apr 2015 17:30:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 749C8E08AC for ; Tue, 21 Apr 2015 17:30:43 +0000 (UTC) Received: from [10.0.31.145] (unknown [100.42.98.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 5681A340967; Tue, 21 Apr 2015 17:30:42 +0000 (UTC) Message-ID: <5536893B.7030904@gentoo.org> Date: Tue, 21 Apr 2015 10:30:35 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: Zac Medico , gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] Re: [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK References: <1429559160-11646-1-git-send-email-bertrand@jacquin.bzh> <55358E1D.1070801@gentoo.org> <55359BBB.4080605@gentoo.org> <5536889E.5050200@gentoo.org> In-Reply-To: <5536889E.5050200@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 803004f6-9cd6-4b8e-afcd-2df8d1263fe3 X-Archives-Hash: 4a8ca2f2c4070ebb111dddd4155280f8 On 04/21/2015 10:27 AM, Zac Medico wrote: > On 04/21/2015 02:48 AM, Duncan wrote: >> Zac Medico posted on Mon, 20 Apr 2015 17:37:15 -0700 as excerpted: >> >>> On 04/20/2015 05:31 PM, Bertrand Jacquin wrote: >>>> On 21/04/2015 00:39, Zac Medico wrote: >>>>> These are in the master branch now: >>>>> >>>>> https://gitweb.gentoo.org/proj/portage.git/commit/? >> id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911 >>>>> >>>>> https://gitweb.gentoo.org/proj/portage.git/commit/? >> id=e74e2670e3f043608fced9847e54bdbb19f35169 >>>>> >>>> >>>> Thanks for that :) >>>> >>>>> I modified the test as follows in order to ensure that it still works >>>>> with shell globs: >>>>> >>>>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo >>>>> "${root}"/${no_inst}) ]] ; then >>>> >>>> I do not really understand the use case here, do you have an example ? >>>> >>>> Cheers, >>>> >>> >>> Well, I don't use INSTALL_MASK myself, so I don't have a real-world >>> use-case for you. However, it's clear that the code will expand shell >>> globs, so I preserved that behavior for compatibility. >> >> I do, with shell globs, tho I didn't bother checking the above to see if >> they'd have been affected. >> >> The two install-masks with globs I use here are: >> >> *.la > > Since it doesn't have an absolute path, this glob is handled by the > find/rm code which comes just after the shell glob code that I was > talking about. > >> (Unmasked on libtool itself, since it has a *.la file that other >> package's .configure scripts test for.) >> >> /etc/cron.*/ >> >> (I use systemd's timers in place of cron and thus crontablets.) > > This is absolute, so it is handled by the shell glob code in question. > Oh, I see what you mean now. It's reconciled by a temporary 'set -o noglob', followed by 'set +o noglob'. -- Thanks, Zac