From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Bertrand Jacquin <bertrand@jacquin.bzh>
Subject: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK
Date: Mon, 20 Apr 2015 16:39:09 -0700 [thread overview]
Message-ID: <55358E1D.1070801@gentoo.org> (raw)
In-Reply-To: <1429559160-11646-1-git-send-email-bertrand@jacquin.bzh>
These are in the master branch now:
https://gitweb.gentoo.org/proj/portage.git/commit/?id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911
https://gitweb.gentoo.org/proj/portage.git/commit/?id=e74e2670e3f043608fced9847e54bdbb19f35169
On 04/20/2015 12:45 PM, Bertrand Jaquin wrote:
>
> # normal stuff
> - rm -Rf "${root}"/${no_inst} >&/dev/null
> + if [[ -e "${root}"/${no_inst} ]] ; then
> + __quiet_mode || einfo "Removing ${no_inst}"
> + rm -Rf "${root}"/${no_inst} >&/dev/null
> + fi
I modified the test as follows in order to ensure that it still works
with shell globs:
if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo
"${root}"/${no_inst}) ]] ; then
--
Thanks,
Zac
next prev parent reply other threads:[~2015-04-20 23:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 19:45 [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK Bertrand Jaquin
2015-04-20 19:46 ` [gentoo-portage-dev] [PATCHv3 2/2] MEDIUM: misc-functions: Be more verbose when removing INSTALL_MASK glob Bertrand Jaquin
2015-04-20 23:39 ` Zac Medico [this message]
2015-04-21 0:31 ` [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK Bertrand Jacquin
2015-04-21 0:37 ` Zac Medico
2015-04-21 9:48 ` [gentoo-portage-dev] " Duncan
2015-04-21 11:21 ` Michael Orlitzky
2015-04-21 17:28 ` Zac Medico
2015-04-21 19:08 ` Michael Orlitzky
2015-04-21 19:20 ` Zac Medico
2015-04-21 17:27 ` Zac Medico
2015-04-21 17:30 ` Zac Medico
2015-04-22 23:44 ` [gentoo-portage-dev] " Bertrand Jacquin
2015-04-23 1:43 ` Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55358E1D.1070801@gentoo.org \
--to=zmedico@gentoo.org \
--cc=bertrand@jacquin.bzh \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox