public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] repoman: fix dependency.unknown to ignore USE deps (bug 545294)
@ 2015-04-02 21:02 Zac Medico
  2015-04-02 23:45 ` [gentoo-portage-dev] [PATCH v2] repoman: fix dependency.unknown to ignore USE deps (bug 525376) Zac Medico
  0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2015-04-02 21:02 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Zac Medico

The surrounding code is ignorant of USE flags, because it calls
use_reduce(matchall=True), therefore it makes sense for the
dependency.unknown code to ignore USE deps.

X-Gentoo-Bug: 545294
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=545294
---
 bin/repoman | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/bin/repoman b/bin/repoman
index 7101a00..64f1ec5 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -2049,9 +2049,10 @@ for x in effective_scanlist:
 
 					# Skip dependency.unknown for blockers, so that we
 					# don't encourage people to remove necessary blockers,
-					# as discussed in bug #382407.
+					# as discussed in bug 382407. We use atom.without_use
+					# due to bug 545294.
 					if not is_blocker and \
-						not portdb.xmatch("match-all", atom) and \
+						not portdb.xmatch("match-all", atom.without_use) and \
 						not atom.cp.startswith("virtual/"):
 						unknown_pkgs.add((mytype, atom.unevaluated_atom))
 
-- 
2.3.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [gentoo-portage-dev] [PATCH v2] repoman: fix dependency.unknown to ignore USE deps (bug 525376)
  2015-04-02 21:02 [gentoo-portage-dev] [PATCH] repoman: fix dependency.unknown to ignore USE deps (bug 545294) Zac Medico
@ 2015-04-02 23:45 ` Zac Medico
  2015-04-10 12:41   ` Alexander Berntsen
  0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2015-04-02 23:45 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Zac Medico

The surrounding code is ignorant of USE flags, because it calls
use_reduce(matchall=True), therefore it makes sense for the
dependency.unknown code to ignore USE deps.

X-Gentoo-Bug: 525376
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=525376
---
[PATCH v2] only changes the bug references from bug 545294 to bug 525376

 bin/repoman | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/bin/repoman b/bin/repoman
index 7101a00..4a21e37 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -2049,9 +2049,10 @@ for x in effective_scanlist:
 
 					# Skip dependency.unknown for blockers, so that we
 					# don't encourage people to remove necessary blockers,
-					# as discussed in bug #382407.
+					# as discussed in bug 382407. We use atom.without_use
+					# due to bug 525376.
 					if not is_blocker and \
-						not portdb.xmatch("match-all", atom) and \
+						not portdb.xmatch("match-all", atom.without_use) and \
 						not atom.cp.startswith("virtual/"):
 						unknown_pkgs.add((mytype, atom.unevaluated_atom))
 
-- 
2.3.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH v2] repoman: fix dependency.unknown to ignore USE deps (bug 525376)
  2015-04-02 23:45 ` [gentoo-portage-dev] [PATCH v2] repoman: fix dependency.unknown to ignore USE deps (bug 525376) Zac Medico
@ 2015-04-10 12:41   ` Alexander Berntsen
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Berntsen @ 2015-04-10 12:41 UTC (permalink / raw
  To: gentoo-portage-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

LGTM.
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iF4EAREIAAYFAlUnxQ4ACgkQRtClrXBQc7UP8QD+Iq4W+HzjGUKjwLNdbu5uTGQI
TyhjfgtLvnJ6o79YSqEA/itSVGwXxmUfhzxWv7mWlaW3jOUSp6k79EkemWUPRTiN
=S8b0
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-10 12:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-02 21:02 [gentoo-portage-dev] [PATCH] repoman: fix dependency.unknown to ignore USE deps (bug 545294) Zac Medico
2015-04-02 23:45 ` [gentoo-portage-dev] [PATCH v2] repoman: fix dependency.unknown to ignore USE deps (bug 525376) Zac Medico
2015-04-10 12:41   ` Alexander Berntsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox