From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 88C4B138A1A for ; Tue, 17 Feb 2015 19:59:12 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 16DB7E086D; Tue, 17 Feb 2015 19:59:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7C3C7E0804 for ; Tue, 17 Feb 2015 19:59:11 +0000 (UTC) Received: from [10.0.31.59] (unknown [100.42.98.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 8CDA133BF44 for ; Tue, 17 Feb 2015 19:59:10 +0000 (UTC) Message-ID: <54E39D8C.9050704@gentoo.org> Date: Tue, 17 Feb 2015 11:59:08 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 1/2] Add FEATURES=binpkg-multi-instance (bug 150031) References: <1424162233-25071-1-git-send-email-zmedico@gentoo.org> <20150217104240.1db9be28.dolsen@gentoo.org> <54E395E3.6060500@gentoo.org> <20150217115607.0eccc56a.dolsen@gentoo.org> In-Reply-To: <20150217115607.0eccc56a.dolsen@gentoo.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: c91950dc-57ca-4dd6-94ae-985282496dbd X-Archives-Hash: ab1971cddd7a567200872fda45a2877e On 02/17/2015 11:56 AM, Brian Dolbec wrote: > On Tue, 17 Feb 2015 11:26:27 -0800 > Zac Medico wrote: > >> On 02/17/2015 10:42 AM, Brian Dolbec wrote: >>> >>> overall, there is no way I know the code well enough to know if you >>> screwed up. But the code looks decent, so... >>> >>> My only questions are: >>> >>> pym/portage/dbapi/bintree.py: >>> >>> You removed several functions from the binarytree class and >>> essentially reduced prevent_collision to a warning message. Can >>> you briefly say why they are not needed please. >> >> Okay, I'll include this info in an updated patch: >> > > Actually, I think this one patch could be split into a few logical > ones. Tag them > > binpkg-multi-instance 1 of... > > in the commit message so it is clear they > belong together. That way the commit messages can more clearly be > relevant to the file(s) changed. > > The commit message is already a short story in length ;) before adding > these new explanations. Okay, will do. -- Thanks, Zac