From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4B602138A1A for ; Tue, 17 Feb 2015 19:37:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 48087E0876; Tue, 17 Feb 2015 19:37:48 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B2DC3E086B for ; Tue, 17 Feb 2015 19:37:47 +0000 (UTC) Received: from [10.0.31.59] (unknown [100.42.98.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id BA0873406AD for ; Tue, 17 Feb 2015 19:37:46 +0000 (UTC) Message-ID: <54E39888.8060904@gentoo.org> Date: Tue, 17 Feb 2015 11:37:44 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 2/2] Add profile-formats=build-id (bug 150031) References: <1424162233-25071-1-git-send-email-zmedico@gentoo.org> <1424162233-25071-2-git-send-email-zmedico@gentoo.org> <20150217105831.424731db.dolsen@gentoo.org> In-Reply-To: <20150217105831.424731db.dolsen@gentoo.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Archives-Salt: 470afa46-7e37-463e-b1ea-46b281bcfe07 X-Archives-Hash: 73a004ffc6491a3655e09f044f79279c On 02/17/2015 10:58 AM, Brian Dolbec wrote: > > class Atom() > > if allow_repo is None: > allow_repo = True > + if allow_build_id is None: > + allow_build_id = True > > > these can be written as > allow_repo = allow_repo or True > allow_build_id = allow_build_id or True Actually, your version behaves differently than mine for the case where False has been passed in for these parameters. The parameters are designed are provide a "smart" default, as long as the caller has not passed in an explicit True or False value. -- Thanks, Zac