From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D3FDD138A1A for ; Thu, 5 Feb 2015 14:51:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4EA47E0875; Thu, 5 Feb 2015 14:51:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BAAB5E0874 for ; Thu, 5 Feb 2015 14:51:39 +0000 (UTC) Received: from [10.0.10.194] (unknown [195.254.219.2]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: bernalex) by smtp.gentoo.org (Postfix) with ESMTPSA id 5AF1D34077C for ; Thu, 5 Feb 2015 14:51:38 +0000 (UTC) Message-ID: <54D38376.60901@gentoo.org> Date: Thu, 05 Feb 2015 15:51:34 +0100 From: Alexander Berntsen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..." References: <20150118014159.4b1104e8.dolsen@gentoo.org> <1421577229-4661-1-git-send-email-mgorny@gentoo.org> <20150118083317.23ab8d0f.dolsen@gentoo.org> In-Reply-To: <20150118083317.23ab8d0f.dolsen@gentoo.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: d4a1ad98-cf09-42f2-9bf7-f85ecbba6fd2 X-Archives-Hash: 427fa8ee1a74862d87cf9875ed691516 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 18/01/15 17:33, Brian Dolbec wrote: > Yeah, just move this to sorted order like Arfrever said. Otherwise > it looks good, ready to merge. Friends, I want to strongly discourage ACKs like "this looks good, but change this one thing before you push". Anyone can make a typo or other error in between such revisions. I would strongly prefer if we required a review of the patch that is to be pushed. - -- Alexander bernalex@gentoo.org https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlTTg3YACgkQRtClrXBQc7VWowD9HU+6r60LVNVXRC6B2W5oetIg +olHBuauHEA7FCVYANUA/04B9hq8Njy+osgtiWeI4ZFG0WukkKDzEsOS5+d6wDg6 =8gwQ -----END PGP SIGNATURE-----