From: Alexander Berntsen <bernalex@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..."
Date: Thu, 05 Feb 2015 15:51:34 +0100 [thread overview]
Message-ID: <54D38376.60901@gentoo.org> (raw)
In-Reply-To: <20150118083317.23ab8d0f.dolsen@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 18/01/15 17:33, Brian Dolbec wrote:
> Yeah, just move this to sorted order like Arfrever said. Otherwise
> it looks good, ready to merge.
Friends,
I want to strongly discourage ACKs like "this looks good, but change
this one thing before you push". Anyone can make a typo or other error
in between such revisions. I would strongly prefer if we required a
review of the patch that is to be pushed.
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlTTg3YACgkQRtClrXBQc7VWowD9HU+6r60LVNVXRC6B2W5oetIg
+olHBuauHEA7FCVYANUA/04B9hq8Njy+osgtiWeI4ZFG0WukkKDzEsOS5+d6wDg6
=8gwQ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-02-05 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 11:58 [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth) Michał Górny
2015-01-17 22:04 ` Zac Medico
2015-01-18 9:41 ` Brian Dolbec
2015-01-18 10:33 ` [gentoo-portage-dev] [PATCH v2] sync: support sync-depth " Michał Górny
2015-01-18 16:33 ` Brian Dolbec
2015-02-05 14:51 ` Alexander Berntsen [this message]
2015-02-05 16:34 ` [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..." Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D38376.60901@gentoo.org \
--to=bernalex@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox