public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH v2] Support escaping network-sandbox through SOCKSv5 proxy
Date: Sun, 25 Jan 2015 13:58:49 -0800	[thread overview]
Message-ID: <54C56719.8090909@gentoo.org> (raw)
In-Reply-To: <1422194414-31669-1-git-send-email-mgorny@gentoo.org>

On 01/25/2015 06:00 AM, Michał Górny wrote:
> +	def __bool__(self):a
> +		return self.socket_path is not None

You should also implement __nonzero__ for python-2.x.
-- 
Thanks,
Zac


      parent reply	other threads:[~2015-01-25 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 14:00 [gentoo-portage-dev] [PATCH v2] Support escaping network-sandbox through SOCKSv5 proxy Michał Górny
2015-01-25 21:43 ` Zac Medico
2015-01-25 22:01   ` Michał Górny
2015-01-25 21:47 ` Zac Medico
2015-01-25 21:58 ` Zac Medico [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C56719.8090909@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox