From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4C1EA138A1A for ; Sun, 18 Jan 2015 01:10:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6FBA8E08FB; Sun, 18 Jan 2015 01:10:20 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DD441E0893 for ; Sun, 18 Jan 2015 01:10:19 +0000 (UTC) Received: from [192.168.0.13] (ip174-67-205-96.oc.oc.cox.net [174.67.205.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id CD8BD3406F6; Sun, 18 Jan 2015 01:10:18 +0000 (UTC) Message-ID: <54BB07F8.7030300@gentoo.org> Date: Sat, 17 Jan 2015 17:10:16 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org CC: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Subject: Re: [gentoo-portage-dev] [PATCH] cvs sync: fix the module References: <1421516218-6706-1-git-send-email-mgorny@gentoo.org> In-Reply-To: <1421516218-6706-1-git-send-email-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 4a4182c8-3efc-4553-94af-b7f41b7b0fa1 X-Archives-Hash: 78d2aee24890734dd73e3bdec4b8bbbc On 01/17/2015 09:36 AM, Michał Górny wrote: > Fix the cvs sync module since it doesn't work at all right now. More > specifically: > > 1. add exists() method that checks for the 'CVS' sub-directory to determine > whether the repository was checked out already. > > 2. Do not remove the just-created directory on initial clone, to avoid > permission issues. Just run checkout on top of it. > > 3. Fix the sync method to run update unconditionally to whether the URI > starts with cvs:// or not. In fact, remove the whole check since it > doesn't serve any purpose. > --- > pym/portage/sync/modules/cvs/cvs.py | 36 ++++++++++++++---------------------- > 1 file changed, 14 insertions(+), 22 deletions(-) LGTM. -- Thanks, Zac