From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] cvs sync: fix the module
Date: Sat, 17 Jan 2015 17:10:16 -0800 [thread overview]
Message-ID: <54BB07F8.7030300@gentoo.org> (raw)
In-Reply-To: <1421516218-6706-1-git-send-email-mgorny@gentoo.org>
On 01/17/2015 09:36 AM, Michał Górny wrote:
> Fix the cvs sync module since it doesn't work at all right now. More
> specifically:
>
> 1. add exists() method that checks for the 'CVS' sub-directory to determine
> whether the repository was checked out already.
>
> 2. Do not remove the just-created directory on initial clone, to avoid
> permission issues. Just run checkout on top of it.
>
> 3. Fix the sync method to run update unconditionally to whether the URI
> starts with cvs:// or not. In fact, remove the whole check since it
> doesn't serve any purpose.
> ---
> pym/portage/sync/modules/cvs/cvs.py | 36 ++++++++++++++----------------------
> 1 file changed, 14 insertions(+), 22 deletions(-)
LGTM.
--
Thanks,
Zac
next prev parent reply other threads:[~2015-01-18 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 17:36 [gentoo-portage-dev] [PATCH] cvs sync: fix the module Michał Górny
2015-01-18 1:10 ` Zac Medico [this message]
2015-01-18 17:01 ` Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BB07F8.7030300@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox