From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3D33F138A1A for ; Sun, 18 Jan 2015 00:13:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 501BAE0841; Sun, 18 Jan 2015 00:13:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C6078E0828 for ; Sun, 18 Jan 2015 00:13:03 +0000 (UTC) Received: from [192.168.0.13] (ip174-67-205-96.oc.oc.cox.net [174.67.205.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 9E3783406C0; Sun, 18 Jan 2015 00:13:02 +0000 (UTC) Message-ID: <54BAFA8C.7030100@gentoo.org> Date: Sat, 17 Jan 2015 16:13:00 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org CC: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Subject: Re: [gentoo-portage-dev] [PATCH] svn sync: fix the module References: <1421516139-6662-1-git-send-email-mgorny@gentoo.org> In-Reply-To: <1421516139-6662-1-git-send-email-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 170261c9-6256-4199-88e9-58a89ca09d75 X-Archives-Hash: e670d2acfba9c0cec04eb1db0b50ae51 On 01/17/2015 09:35 AM, Michał Górny wrote: > Fix the svn sync module since it doesn't work at all right now. More > specifically: > > 1. add exists() method that uses 'svn info' to determine whether > the repository was checked out already. > > 2. Fix the initial clone to use valid svn commands. Do not remove > the just-created directory to avoid permission issues, just run checkout > on top of it. In case the reader is wondering, we could clarify that SyncManager.pre_sync creates the directory and sets the permissions. > 3. Fix the sync method to run update unconditionally to whether the URI > starts with svn:// or not. In fact, remove the whole check since it > doesn't serve any purpose. > --- > pym/portage/sync/modules/svn/svn.py | 54 ++++++++++++++++++++----------------- > 1 file changed, 29 insertions(+), 25 deletions(-) LGTM. -- Thanks, Zac