Re: [gentoo-portage-dev] [PATCH] svn sync: fix the module

[Zac Medico <zmedico@gentoo.org>]

On 01/17/2015 09:35 AM, Michał Górny wrote:
> Fix the svn sync module since it doesn't work at all right now. More
> specifically:
> 
> 1. add exists() method that uses 'svn info' to determine whether
> the repository was checked out already.
> 
> 2. Fix the initial clone to use valid svn commands. Do not remove
> the just-created directory to avoid permission issues, just run checkout
> on top of it.

In case the reader is wondering, we could clarify that
SyncManager.pre_sync creates the directory and sets the permissions.

> 3. Fix the sync method to run update unconditionally to whether the URI
> starts with svn:// or not. In fact, remove the whole check since it
> doesn't serve any purpose.
> ---
>  pym/portage/sync/modules/svn/svn.py | 54 ++++++++++++++++++++-----------------
>  1 file changed, 29 insertions(+), 25 deletions(-)

LGTM.
-- 
Thanks,
Zac