From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1C1B3138A1A for ; Sat, 17 Jan 2015 23:43:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 58D62E09C2; Sat, 17 Jan 2015 23:43:53 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CC374E09B6 for ; Sat, 17 Jan 2015 23:43:52 +0000 (UTC) Received: from [192.168.0.13] (ip174-67-205-96.oc.oc.cox.net [174.67.205.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 717E8340723; Sat, 17 Jan 2015 23:43:51 +0000 (UTC) Message-ID: <54BAF3B4.7090705@gentoo.org> Date: Sat, 17 Jan 2015 15:43:48 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org CC: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Subject: Re: [gentoo-portage-dev] [PATCH] sync: unify syncing messages and reduce noise References: <1421502914-5948-1-git-send-email-mgorny@gentoo.org> In-Reply-To: <1421502914-5948-1-git-send-email-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 49a3ff70-621c-4346-b274-25c2b6e4226a X-Archives-Hash: c37356f269960513f0e64493aef02350 On 01/17/2015 05:55 AM, Michał Górny wrote: > Print single ">>> Syncing repository '%s' into '%s'..." before syncing, > and single "=== Sync completed for %s" after successful sync. > > Remove duplicate in-module clone/pull messages. Instead, verbosely print > git commands executed. > > Remove useless verbosity in pre-sync mkdir. > --- > pym/portage/sync/controller.py | 8 +++++--- > pym/portage/sync/modules/cvs/cvs.py | 6 ------ > pym/portage/sync/modules/git/git.py | 31 +++++++++++------------------ > pym/portage/sync/modules/rsync/rsync.py | 2 +- > pym/portage/sync/modules/svn/svn.py | 6 ------ > pym/portage/sync/modules/websync/websync.py | 6 ------ > 6 files changed, 18 insertions(+), 41 deletions(-) LGTM. -- Thanks, Zac