From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] sync: unify syncing messages and reduce noise
Date: Sat, 17 Jan 2015 15:43:48 -0800 [thread overview]
Message-ID: <54BAF3B4.7090705@gentoo.org> (raw)
In-Reply-To: <1421502914-5948-1-git-send-email-mgorny@gentoo.org>
On 01/17/2015 05:55 AM, Michał Górny wrote:
> Print single ">>> Syncing repository '%s' into '%s'..." before syncing,
> and single "=== Sync completed for %s" after successful sync.
>
> Remove duplicate in-module clone/pull messages. Instead, verbosely print
> git commands executed.
>
> Remove useless verbosity in pre-sync mkdir.
> ---
> pym/portage/sync/controller.py | 8 +++++---
> pym/portage/sync/modules/cvs/cvs.py | 6 ------
> pym/portage/sync/modules/git/git.py | 31 +++++++++++------------------
> pym/portage/sync/modules/rsync/rsync.py | 2 +-
> pym/portage/sync/modules/svn/svn.py | 6 ------
> pym/portage/sync/modules/websync/websync.py | 6 ------
> 6 files changed, 18 insertions(+), 41 deletions(-)
LGTM.
--
Thanks,
Zac
next prev parent reply other threads:[~2015-01-17 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 13:55 [gentoo-portage-dev] [PATCH] sync: unify syncing messages and reduce noise Michał Górny
2015-01-17 23:43 ` Zac Medico [this message]
2015-01-18 16:47 ` Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BAF3B4.7090705@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox