From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E7EBF138A1A for ; Sat, 17 Jan 2015 22:41:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4C6D9E097D; Sat, 17 Jan 2015 22:41:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AC1EFE096D for ; Sat, 17 Jan 2015 22:41:50 +0000 (UTC) Received: from [192.168.0.13] (ip174-67-205-96.oc.oc.cox.net [174.67.205.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id BB3963406C4; Sat, 17 Jan 2015 22:41:49 +0000 (UTC) Message-ID: <54BAE52B.7050507@gentoo.org> Date: Sat, 17 Jan 2015 14:41:47 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org CC: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Subject: Re: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration References: <1421500603-15692-1-git-send-email-mgorny@gentoo.org> In-Reply-To: <1421500603-15692-1-git-send-email-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: cfad4a3a-f313-44eb-8531-a4c0179e1ac7 X-Archives-Hash: 1df67821b79647b3d6854e89e11b6592 On 01/17/2015 05:16 AM, Michał Górny wrote: > Fix module_names enumeration to consider all modules. Before, the first > module on the list was omitted ('cvs' in this case). > > Another thing is, the CVS module is completely, utterly and inevitably > broken. And the whole syncing thing is a great pile of terribly > mis-designed, unnecessarily complex code which can't work unless it is > worked around like git module does... > --- > pym/portage/sync/controller.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM, except this commit message is not a proper place to rant about stuff... -- Thanks, Zac