From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration
Date: Sat, 17 Jan 2015 14:41:47 -0800 [thread overview]
Message-ID: <54BAE52B.7050507@gentoo.org> (raw)
In-Reply-To: <1421500603-15692-1-git-send-email-mgorny@gentoo.org>
On 01/17/2015 05:16 AM, Michał Górny wrote:
> Fix module_names enumeration to consider all modules. Before, the first
> module on the list was omitted ('cvs' in this case).
>
> Another thing is, the CVS module is completely, utterly and inevitably
> broken. And the whole syncing thing is a great pile of terribly
> mis-designed, unnecessarily complex code which can't work unless it is
> worked around like git module does...
> ---
> pym/portage/sync/controller.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM, except this commit message is not a proper place to rant about
stuff...
--
Thanks,
Zac
next prev parent reply other threads:[~2015-01-17 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 13:16 [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration Michał Górny
2015-01-17 22:41 ` Zac Medico [this message]
2015-01-18 9:49 ` Brian Dolbec
2015-01-18 10:32 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BAE52B.7050507@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox