From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] Support override of default profile EAPI (532670)
Date: Mon, 22 Dec 2014 11:54:36 -0800 [thread overview]
Message-ID: <549876FC.3050407@gentoo.org> (raw)
In-Reply-To: <54986418.1070903@gentoo.org>
On 12/22/2014 10:34 AM, Zac Medico wrote:
> On 12/22/2014 04:59 AM, Alexander Berntsen wrote:
>> The idea presented in the commit message header is very good. The
>> implementation discussed in the commit message body sounds a bit
>> messy, but I can't immediately think of another way to support this.
>
> Given existing state of the code, I think my implementation is quite
> reasonable. It's seems a bit messy because the functions/methods
> involved need to deal with 3 different kinds of profile nodes:
>
> 1) Regular profile nodes
>
> 2) User profile override directory in /etc/portage/profile
>
> 3) The root "profiles" directory, which is not really a profile node,
> but is used for repository-level configurations (package.mask being the
> most common example used by Gentoo)
>
> I will add a note about this to the commit message, since it's not
> completely obvious unless you have had to dive into this code for some
> reason.
The updated commit message is here:
https://github.com/zmedico/portage/commit/582965f8e8f0071d50abe2e9510abe6659e10242
--
Thanks,
Zac
prev parent reply other threads:[~2014-12-22 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 19:39 [gentoo-portage-dev] [PATCH] Support override of default profile EAPI (532670) Zac Medico
2014-12-22 12:59 ` Alexander Berntsen
2014-12-22 18:34 ` Zac Medico
2014-12-22 19:54 ` Zac Medico [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549876FC.3050407@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox