Re: [gentoo-portage-dev] [PATCH] Support override of default profile EAPI (532670)

[Zac Medico <zmedico@gentoo.org>]

On 12/22/2014 04:59 AM, Alexander Berntsen wrote:
> The idea presented in the commit message header is very good. The
> implementation discussed in the commit message body sounds a bit
> messy, but I can't immediately think of another way to support this.

Given existing state of the code, I think my implementation is quite
reasonable. It's seems a bit messy because the functions/methods
involved need to deal with 3 different kinds of profile nodes:

1) Regular profile nodes

2) User profile override directory in /etc/portage/profile

3) The root "profiles" directory, which is not really a profile node,
but is used for repository-level configurations (package.mask being the
most common example used by Gentoo)

I will add a note about this to the commit message, since it's not
completely obvious unless you have had to dive into this code for some
reason.

> Can you? Can anyone else?

No, not without making extensive changes to the existing code (probably
without much payoff). However, the changes that I've made do produce the
intended result, and they make the existing code more flexible by making
it possible to override the repository-level default. My changes also
significantly reduce the number of read_corresponding_eapi_file calls,
which seems more organized because this way a given node's EAPI only
needs to be determined once rather than through repeated (memoized)
calls to read_corresponding_eapi_file.

> I'd like to have more of a discussion before this is merged.

Yeah, it's good to have others check my work, because there are lots of
opportunities for small logic errors here. However, I'm confident that
the current patch is bug-free, since I have tested many different
scenarios by tweaking values in the unit test.

> The patch itself looks OK though.

Great, thanks for your feedback!
-- 
Thanks,
Zac