From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A94BF1389E2 for ; Sat, 13 Dec 2014 18:43:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 97DADE0E2A; Sat, 13 Dec 2014 18:43:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 255E7E0E29 for ; Sat, 13 Dec 2014 18:43:17 +0000 (UTC) Received: from [192.168.1.16] (ip70-181-96-121.oc.oc.cox.net [70.181.96.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 494163405CA for ; Sat, 13 Dec 2014 18:43:16 +0000 (UTC) Message-ID: <548C88C2.4030601@gentoo.org> Date: Sat, 13 Dec 2014 10:43:14 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] emerge --info: Check metadata/timestamp.chk in all repositories References: <201412131833.04573.Arfrever.FTA@gmail.com> In-Reply-To: <201412131833.04573.Arfrever.FTA@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 35d2898b-b980-4698-91e2-65acda82be8f X-Archives-Hash: 4ac01d09ec670c6e27f1d4ea3772c05f On 12/13/2014 09:33 AM, Arfrever Frehtes Taifersar Arahesis wrote: > [[[ > emerge --info: Check metadata/timestamp.chk in all repositories. > > 1 use of deprecated PORTDIR has been deleted. > ]]] > > -- > Arfrever Frehtes Taifersar Arahesis > LGTM. However, I dislike the os.path.isfile() call, because it's a redundant stat call. Can't we just call grabfile, and ignore any exception that it may raise? -- Thanks, Zac