From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] sync: allow overriding sync-user for the repository
Date: Sun, 07 Dec 2014 10:32:04 -0800 [thread overview]
Message-ID: <54849D24.3060905@gentoo.org> (raw)
In-Reply-To: <20141207100708.2364d4fe@pomiot.lan>
On 12/07/2014 01:07 AM, Michał Górny wrote:
> Dnia 2014-12-07, o godz. 10:01:23
> Michał Górny <mgorny@gentoo.org> napisał(a):
>
>> + if uid is not None
>
> Missing ':' here, I won't resend the patch for it :P.
>
>> + spawn_kwargs["uid"] = uid
>> + self.usersync_uid = uid
>> + if gid is not None:
>> + spawn_kwargs["gid"] = gid
>> + spawn_kwargs["groups"] = [gid]
>> + if home is not None:
>> + spawn_kwargs["env"]["HOME"] = home
>> + elif ('usersync' in self.settings.features and
>> portage.data.secpass >= 2 and
>> (st.st_uid != os.getuid() and st.st_mode & 0o700 or
>> st.st_gid != os.getgid() and st.st_mode & 0o070)):
>
>
>
LGTM.
--
Thanks,
Zac
next prev parent reply other threads:[~2014-12-07 18:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 0:03 [gentoo-portage-dev] [PATCH 0/4] sync: sync-umask and sync-user support Michał Górny
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 1/4] sync: allow overriding sync-umask for the repository Michał Górny
2014-12-07 6:46 ` Zac Medico
2014-12-07 9:00 ` [gentoo-portage-dev] [PATCH] " Michał Górny
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 2/4] sync: allow overriding sync-user " Michał Górny
2014-12-07 7:02 ` Zac Medico
2014-12-07 9:01 ` [gentoo-portage-dev] [PATCH] " Michał Górny
2014-12-07 9:07 ` Michał Górny
2014-12-07 18:32 ` Zac Medico [this message]
2014-12-08 6:53 ` Arfrever Frehtes Taifersar Arahesis
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 3/4] sync: ensure sync_{umask,user} is respected when creating repo Michał Górny
2014-12-07 7:10 ` Zac Medico
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 4/4] sync: Add backwards compat with SYNC_{UMASK,USER} variables Michał Górny
2014-12-07 7:15 ` Zac Medico
2014-12-07 8:22 ` Michał Górny
2014-12-07 9:04 ` Zac Medico
2014-12-07 9:06 ` Michał Górny
2014-12-07 18:33 ` Zac Medico
2014-12-07 18:39 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54849D24.3060905@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox