From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 053ED1389E2 for ; Sun, 7 Dec 2014 18:26:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8ECE9E0C33; Sun, 7 Dec 2014 18:26:21 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 10551E0B78 for ; Sun, 7 Dec 2014 18:26:21 +0000 (UTC) Received: from [192.168.1.4] (ip70-181-96-121.oc.oc.cox.net [70.181.96.121]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 383ED34052F; Sun, 7 Dec 2014 18:26:20 +0000 (UTC) Message-ID: <54849BC8.8040106@gentoo.org> Date: Sun, 07 Dec 2014 10:26:16 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: Zac Medico , gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 1/2] bin/phase-helpers.shL Fix unpack() for deb2targz .xz types References: <20141206165201.0dc3ea1c.dolsen@gentoo.org> <54849466.8080203@gentoo.org> In-Reply-To: <54849466.8080203@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: a7bd5008-2699-458a-a5e2-620acd13698a X-Archives-Hash: a37945ca08ac8ab15e077fca191ba821 On 12/07/2014 09:54 AM, Zac Medico wrote: > On 12/06/2014 04:52 PM, Brian Dolbec wrote: >> >> From 4cb661d994cf8503c4459b8f7da7ee0f739a9826 Mon Sep 17 00:00:00 2001 >> From: Brian Dolbec >> Date: Sat, 6 Dec 2014 14:51:13 -0800 >> Subject: [PATCH 1/2] bin/phase-helpers.shL Fix unpack() for deb2targz .xz types >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit > > LGTM, given that other package managers default to 'ar x' which already > works with xz files. Based on discussion with Ulrich Mueller I think we should default to ar if [[ $(ar --version 2>&1) == "GNU ar"* ]] and otherwise fall back to deb2targz. -- Thanks, Zac