From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 84C2C1389E2 for ; Sun, 7 Dec 2014 09:04:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E521DE0931; Sun, 7 Dec 2014 09:04:25 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 54BCCE0930 for ; Sun, 7 Dec 2014 09:04:25 +0000 (UTC) Received: from [192.168.1.4] (ip70-181-96-121.oc.oc.cox.net [70.181.96.121]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 58A12340341; Sun, 7 Dec 2014 09:04:24 +0000 (UTC) Message-ID: <54841813.8060203@gentoo.org> Date: Sun, 07 Dec 2014 01:04:19 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= CC: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 4/4] sync: Add backwards compat with SYNC_{UMASK,USER} variables References: <1417824216-7990-1-git-send-email-mgorny@gentoo.org> <1417824216-7990-5-git-send-email-mgorny@gentoo.org> <5483FE7D.3060302@gentoo.org> <20141207092207.7070d75c@pomiot.lan> In-Reply-To: <20141207092207.7070d75c@pomiot.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 0229a29f-4353-4656-803b-549972e2c2cd X-Archives-Hash: b3f98a7abda9e850efbc358718495a09 On 12/07/2014 12:22 AM, Michał Górny wrote: > Dnia 2014-12-06, o godz. 23:15:09 > Zac Medico napisał(a): > >> On 12/05/2014 04:03 PM, Michał Górny wrote: >>> Support SYNC_UMASK and SYNC_USER variables that were used in Funtoo >>> Portage, as fallbacks to sync-umask and sync-user repo keys. >>> --- >>> pym/portage/package/ebuild/_config/special_env_vars.py | 2 +- >>> pym/portage/package/ebuild/config.py | 12 ++++++++++++ >>> pym/portage/repository/config.py | 13 +++++++++++++ >>> 3 files changed, 26 insertions(+), 1 deletion(-) >> >> Why should we add backward compatibility code for something that was >> never supported in the master branch? > > I just thought it wouldn't hurt if we're backporting features. Adding extra code for new redundant variables seems undesirable. Are they somehow better than using equivalent repos.conf [DEFAULT] settings for sync-user and sync-mask? -- Thanks, Zac