From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CF7551389E2 for ; Sun, 7 Dec 2014 07:15:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E6389E0921; Sun, 7 Dec 2014 07:15:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 60893E0908 for ; Sun, 7 Dec 2014 07:15:14 +0000 (UTC) Received: from [192.168.1.4] (ip70-181-96-121.oc.oc.cox.net [70.181.96.121]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 87EF73402E6; Sun, 7 Dec 2014 07:15:13 +0000 (UTC) Message-ID: <5483FE7D.3060302@gentoo.org> Date: Sat, 06 Dec 2014 23:15:09 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org CC: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Subject: Re: [gentoo-portage-dev] [PATCH 4/4] sync: Add backwards compat with SYNC_{UMASK,USER} variables References: <1417824216-7990-1-git-send-email-mgorny@gentoo.org> <1417824216-7990-5-git-send-email-mgorny@gentoo.org> In-Reply-To: <1417824216-7990-5-git-send-email-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: b49b4fd9-2e5d-478e-b814-67066e4722ce X-Archives-Hash: 1bbb79e1b837b4aff7972dd3f97c10a2 On 12/05/2014 04:03 PM, Michał Górny wrote: > Support SYNC_UMASK and SYNC_USER variables that were used in Funtoo > Portage, as fallbacks to sync-umask and sync-user repo keys. > --- > pym/portage/package/ebuild/_config/special_env_vars.py | 2 +- > pym/portage/package/ebuild/config.py | 12 ++++++++++++ > pym/portage/repository/config.py | 13 +++++++++++++ > 3 files changed, 26 insertions(+), 1 deletion(-) Why should we add backward compatibility code for something that was never supported in the master branch? Wouldn't it make more sense to have the Funtoo ebuild run some code that generates a config update for repos.conf? -- Thanks, Zac