From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH 4/4] sync: Add backwards compat with SYNC_{UMASK,USER} variables
Date: Sat, 06 Dec 2014 23:15:09 -0800 [thread overview]
Message-ID: <5483FE7D.3060302@gentoo.org> (raw)
In-Reply-To: <1417824216-7990-5-git-send-email-mgorny@gentoo.org>
On 12/05/2014 04:03 PM, Michał Górny wrote:
> Support SYNC_UMASK and SYNC_USER variables that were used in Funtoo
> Portage, as fallbacks to sync-umask and sync-user repo keys.
> ---
> pym/portage/package/ebuild/_config/special_env_vars.py | 2 +-
> pym/portage/package/ebuild/config.py | 12 ++++++++++++
> pym/portage/repository/config.py | 13 +++++++++++++
> 3 files changed, 26 insertions(+), 1 deletion(-)
Why should we add backward compatibility code for something that was
never supported in the master branch?
Wouldn't it make more sense to have the Funtoo ebuild run some code that
generates a config update for repos.conf?
--
Thanks,
Zac
next prev parent reply other threads:[~2014-12-07 7:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 0:03 [gentoo-portage-dev] [PATCH 0/4] sync: sync-umask and sync-user support Michał Górny
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 1/4] sync: allow overriding sync-umask for the repository Michał Górny
2014-12-07 6:46 ` Zac Medico
2014-12-07 9:00 ` [gentoo-portage-dev] [PATCH] " Michał Górny
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 2/4] sync: allow overriding sync-user " Michał Górny
2014-12-07 7:02 ` Zac Medico
2014-12-07 9:01 ` [gentoo-portage-dev] [PATCH] " Michał Górny
2014-12-07 9:07 ` Michał Górny
2014-12-07 18:32 ` Zac Medico
2014-12-08 6:53 ` Arfrever Frehtes Taifersar Arahesis
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 3/4] sync: ensure sync_{umask,user} is respected when creating repo Michał Górny
2014-12-07 7:10 ` Zac Medico
2014-12-06 0:03 ` [gentoo-portage-dev] [PATCH 4/4] sync: Add backwards compat with SYNC_{UMASK,USER} variables Michał Górny
2014-12-07 7:15 ` Zac Medico [this message]
2014-12-07 8:22 ` Michał Górny
2014-12-07 9:04 ` Zac Medico
2014-12-07 9:06 ` Michał Górny
2014-12-07 18:33 ` Zac Medico
2014-12-07 18:39 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5483FE7D.3060302@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox