From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1CD061389E2 for ; Mon, 1 Dec 2014 00:03:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D8F50E08EA; Mon, 1 Dec 2014 00:03:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 77631E08E6 for ; Mon, 1 Dec 2014 00:03:41 +0000 (UTC) Received: from [192.168.1.4] (ip70-181-96-121.oc.oc.cox.net [70.181.96.121]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 5BAA534016B; Mon, 1 Dec 2014 00:03:40 +0000 (UTC) Message-ID: <547BB058.7070905@gentoo.org> Date: Sun, 30 Nov 2014 16:03:36 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: =?ISO-8859-2?Q?Micha=B3_G=F3rny?= , Zac Medico CC: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] Respect nonfatal in unpack(), econf() and einstall() References: <1417349822-18864-1-git-send-email-mgorny@gentoo.org> <1417369005-8771-1-git-send-email-mgorny@gentoo.org> <547B6F58.1060500@gentoo.org> <20141130212549.3106a237@pomiot.lan> In-Reply-To: <20141130212549.3106a237@pomiot.lan> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit X-Archives-Salt: c0fd2841-53a8-4078-9adc-ee972eac35be X-Archives-Hash: 5eafa5a6cff19085f618e3a403e59023 On 11/30/2014 12:25 PM, Michał Górny wrote: > Dnia 2014-11-30, o godz. 11:26:16 > Zac Medico napisał(a): > >> On 11/30/2014 09:36 AM, Michał Górny wrote: >>> @@ -628,7 +665,11 @@ einstall() { >>> sysconfdir="${ED}etc" \ >>> ${LOCAL_EXTRA_EINSTALL} \ >>> ${MAKEOPTS} -j1 \ >>> - "$@" ${EXTRA_EMAKE} install || die "einstall failed" >>> + "$@" ${EXTRA_EMAKE} install >>> + then >>> + __helpers_die "einstall failed" >>> + return 1 >>> + fi >>> else >>> die "no Makefile found" >>> fi >>> >> >> The patch all looks good to me. However, the last die shown in the diff >> context here makes me wonder why that one wasn't converted from die to >> __helpers_die. > > Because it's incorrect use, not a call failure :). I have decided to > use __helpers_die whenever the executed command fails but force die > on asserts and invalid uses. Okay, sounds pretty reasonable to me. -- Thanks, Zac