From: Zac Medico <zmedico@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>, "Zac Medico" <zmedico@gentoo.org>
Cc: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH v2] Respect nonfatal in unpack(), econf() and einstall()
Date: Sun, 30 Nov 2014 16:03:36 -0800 [thread overview]
Message-ID: <547BB058.7070905@gentoo.org> (raw)
In-Reply-To: <20141130212549.3106a237@pomiot.lan>
On 11/30/2014 12:25 PM, Michał Górny wrote:
> Dnia 2014-11-30, o godz. 11:26:16
> Zac Medico <zmedico@gentoo.org> napisał(a):
>
>> On 11/30/2014 09:36 AM, Michał Górny wrote:
>>> @@ -628,7 +665,11 @@ einstall() {
>>> sysconfdir="${ED}etc" \
>>> ${LOCAL_EXTRA_EINSTALL} \
>>> ${MAKEOPTS} -j1 \
>>> - "$@" ${EXTRA_EMAKE} install || die "einstall failed"
>>> + "$@" ${EXTRA_EMAKE} install
>>> + then
>>> + __helpers_die "einstall failed"
>>> + return 1
>>> + fi
>>> else
>>> die "no Makefile found"
>>> fi
>>>
>>
>> The patch all looks good to me. However, the last die shown in the diff
>> context here makes me wonder why that one wasn't converted from die to
>> __helpers_die.
>
> Because it's incorrect use, not a call failure :). I have decided to
> use __helpers_die whenever the executed command fails but force die
> on asserts and invalid uses.
Okay, sounds pretty reasonable to me.
--
Thanks,
Zac
next prev parent reply other threads:[~2014-12-01 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 12:17 [gentoo-portage-dev] [PATCH] Respect nonfatal in unpack(), econf() and einstall() Michał Górny
2014-11-30 17:36 ` [gentoo-portage-dev] [PATCH v2] " Michał Górny
2014-11-30 19:26 ` Zac Medico
2014-11-30 20:25 ` Michał Górny
2014-12-01 0:03 ` Zac Medico [this message]
2014-12-02 19:25 ` [gentoo-portage-dev] [PATCH] " Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547BB058.7070905@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox