Re: [gentoo-portage-dev] [PATCH] Do not try to source stray directories in bashrc paths

[Zac Medico <zmedico@gentoo.org>]

On 11/29/2014 03:30 AM, Michał Górny wrote:
> Check whether a particular bashrc path is not a directory before trying
> to source it. Avoids unnecessary 'is a directory' errors.
> ---
>  bin/ebuild.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/ebuild.sh b/bin/ebuild.sh
> index 658884a..46c3a03 100755
> --- a/bin/ebuild.sh
> +++ b/bin/ebuild.sh
> @@ -421,7 +421,7 @@ __try_source() {
>  		qa=false
>  		shift
>  	fi
> -	if [[ -r "$1" ]]; then
> +	if [[ -r $1 && ! -d $1 ]]; then
>  		local debug_on=false
>  		if [[ "$PORTAGE_DEBUG" == "1" ]] && [[ "${-/x/}" == "$-" ]]; then
>  			debug_on=true
> 

LGTM. Maybe [[ -r $1 && -f $1 ]] makes more sense though, since anything
other that a regular file will simply not work here (-f returns true for
symlinks to regular files, too).
-- 
Thanks,
Zac