From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id F1A32138A1A for ; Mon, 24 Nov 2014 06:55:14 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 747ABE09F6; Mon, 24 Nov 2014 06:55:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DF1FBE09D8 for ; Mon, 24 Nov 2014 06:55:11 +0000 (UTC) Received: from [10.0.10.112] (unknown [195.254.219.2]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: bernalex) by smtp.gentoo.org (Postfix) with ESMTPSA id BBCB833BE9D for ; Mon, 24 Nov 2014 06:55:10 +0000 (UTC) Message-ID: <5472D64A.209@gentoo.org> Date: Mon, 24 Nov 2014 07:55:06 +0100 From: Alexander Berntsen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] Add emerge --with-test-deps option for bug #520652 References: <1415508602-15169-1-git-send-email-zmedico@gentoo.org> <1416477956-26189-1-git-send-email-zmedico@gentoo.org> In-Reply-To: <1416477956-26189-1-git-send-email-zmedico@gentoo.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 69b1ef5d-3dbd-4901-b41b-5cf278bb8623 X-Archives-Hash: 7d53eff1a4c69f9838df6b827885c95f -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 I am unable to fully take into account every possible event this affects in a 10KLOC file full of side-effects file. So I'm going to just trust you and your unit test, and consequently ACK this. The patch, isolated, looks fine to me. - -- Alexander bernalex@gentoo.org https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlRy1koACgkQRtClrXBQc7XmGgD9GdQ6sytqZ5E3fWDIFqyx0LnE fdbDHLJ06XuZF5LO77YA+gOz0ooyTomea9hUGCGaXz1CAz8iOlmthiRCPJ9yI4ma =6dAa -----END PGP SIGNATURE-----