Re: [gentoo-portage-dev] [PATCH] emerge: check for writable /var/db/pkg (490732)

[Zac Medico <zmedico@gentoo.org>]

On 11/18/2014 02:57 AM, Brian Dolbec wrote:
> On Tue, 18 Nov 2014 01:19:01 -0800
> Zac Medico <zmedico@gentoo.org> wrote:
> 
>> If there are packages to be merged or unmerge, then bail out early if
>> /var/db/pkg is not writable.
>>
> ...
> 
>> diff --git a/pym/portage/dbapi/vartree.py
>> b/pym/portage/dbapi/vartree.py index 0fd1bd9..64b0ff6 100644
>> --- a/pym/portage/dbapi/vartree.py
>> +++ b/pym/portage/dbapi/vartree.py
>> @@ -33,6 +33,7 @@ portage.proxy.lazyimport.lazyimport(globals(),
>>  	'portage.util.env_update:env_update',
>>  	'portage.util.listdir:dircache,listdir',
>>  	'portage.util.movefile:movefile',
>> +	'portage.util.path:first_existing',
>>  	'portage.util.writeable_check:get_ro_checker',
> 
>                           ^^^^^^^^^^^^^^^^^^^^^^^^
>        That's what this was suppose to fix I thought

The writeable_check module is designed to check write access for the
files to be merged, and it's only used just prior to merge, when the
list of files is known.

The vardbapi.writable check that I have implemented provides a much
earlier warning, before anything has even been built.
-- 
Thanks,
Zac