Re: [gentoo-portage-dev] [PATCH] unprivileged mode: generate PORTAGE_DEPCACHEDIR

[Zac Medico <zmedico@gentoo.org>]

On 11/10/2014 03:09 AM, Alexander Berntsen wrote:
> On 10/11/14 00:24, Zac Medico wrote:
>> ir
>> +					while current_dir != os.sep:
>> +						try:
>> +							st = os.stat(current_dir)
>> +						except OSError as e:
>> +							if errno == errno.ENOENT:
>> +								current_dir = \
>> +									os.path.dirname(current_dir)
>> +								continue
>> +						break
> Can you think of a less terrible way of doing this in Python?

Well, you'll have to clarify what's so "terrible" about it. Note that I didn't
use os.path.isdir or similar because those functions hide all kinds of relevant
exceptions, such as EACCES.

If it's the continue and break that upset you, we can do it like this:

found_dir = False
while current_dir != os.sep and not found_dir:
	try:
		os.stat(current_dir)
		found_dir  = True
	except OSError:
		if errno == errno.ENOENT:
			current_dir = \
				os.path.dirname(current_dir)
		else:
			found_dir  = True

-- 
Thanks,
Zac