* [gentoo-portage-dev] [PATCH] doebuild: fix bug #528272
@ 2014-11-05 6:33 Zac Medico
2014-11-05 10:31 ` Alexander Berntsen
0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2014-11-05 6:33 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Zac Medico
The doebuild function has a boolean "unpacked" variable which it sets
to True if it determines that the "unpack" phase has already executed
and the last modification times of the distfiles are older than the
last modification time of WORKDIR. The code which sets the "unpacked"
flag does not need to run unless the current phase is supposed to have
a build directory. Therefore, disable this code for all phases that are
not supposed to have a build directory. This fixes incorrect behavior
of the "fetch" phase as reported in bug #528272.
X-Gentoo-Bug: 528272
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=528272
---
pym/portage/package/ebuild/doebuild.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pym/portage/package/ebuild/doebuild.py b/pym/portage/package/ebuild/doebuild.py
index 544d193..6df3c69 100644
--- a/pym/portage/package/ebuild/doebuild.py
+++ b/pym/portage/package/ebuild/doebuild.py
@@ -829,7 +829,8 @@ def doebuild(myebuild, mydo, _unused=DeprecationWarning, settings=None, debug=0,
alist = set(mysettings.configdict["pkg"].get("A", "").split())
unpacked = False
- if tree != "porttree":
+ if tree != "porttree" or \
+ mydo in _doebuild_commands_without_builddir:
pass
elif "unpack" not in phases_to_run:
unpacked = os.path.exists(os.path.join(
--
2.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-05 19:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-05 6:33 [gentoo-portage-dev] [PATCH] doebuild: fix bug #528272 Zac Medico
2014-11-05 10:31 ` Alexander Berntsen
2014-11-05 19:43 ` Zac Medico
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox