From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] depgraph: fix bug #526160
Date: Mon, 27 Oct 2014 02:27:43 -0700 [thread overview]
Message-ID: <544E100F.1060107@gentoo.org> (raw)
In-Reply-To: <544E00B6.4090304@gentoo.org>
On 10/27/2014 01:22 AM, Alexander Berntsen wrote:
> On 27/10/14 08:33, Zac Medico wrote:
>> + if not self._depgraph._virt_deps_visible( + new_child,
>> ignore_use=True): + continue + if pkg < new_child: +
>> return False
> Seems needlessly bit obscure when you could just "if
> self.depgraph._virt_deps_visible(new_child, ignore_use=True) and pkg <
> new_child" or some variant thereof. But it's a minor qualm.
I prefer not to group them into a single expression because they are
separate heuristics. At some point in the future, we may find that we
need to adjust one or both heuristics, add more heuristics, or remove
some heuristics. Keeping the heuristics as separate expressions makes it
easier to do such modifications. It also provides emphasis to the reader
that these are separate heuristics.
> Otherwise LGTM, go ahead & push.
Thanks, it's pushed:
https://github.com/gentoo/portage/commit/d3be49fe6827aa1974856dffe6d5a1aca80a7bed
--
Thanks,
Zac
next prev parent reply other threads:[~2014-10-27 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 1:05 [gentoo-portage-dev] [PATCH] depgraph: fix bug #526160 zmedico
2014-10-27 7:33 ` Zac Medico
2014-10-27 8:22 ` Alexander Berntsen
2014-10-27 8:23 ` Alexander Berntsen
2014-10-27 8:23 ` Alexander Berntsen
2014-10-27 9:27 ` Zac Medico [this message]
2014-11-02 16:49 ` Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E100F.1060107@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox