Re: [gentoo-portage-dev] Re: [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions.

[Zac Medico <zmedico@gentoo.org>]

On 10/26/2014 12:31 PM, Michael Palimaka wrote:
> On 26/10/14 07:57, Zac Medico wrote:
>> On 10/25/2014 01:32 PM, Zac Medico wrote:
>>> On 10/25/2014 01:26 PM, Michał Górny wrote:
>>>> Dnia 2014-10-25, o godz. 12:53:15
>>>> Zac Medico <zmedico@gentoo.org> napisał(a):
>>>>>
>>>>> These functions are internals, so they need to be prefixed with __ like
>>>>> __eqalog and __eqawarnlog.
>>>>
>>>> eqawarnlog shouldn't be internal since we support adding QA checks
>>>> in repositories. In fact, I am planning to move some Gentoo-specific QA
>>>> checks out of portage code.
>>>
>>> It's a PMS thing. If it's not in PMS and the package manager provides
>>> it, it's supposed to be prefixed.
>>
>> Note that we could have unprefixed aliases inside misc-functions.sh,
>> since misc-functions.sh env is never saved.
>>
> 
> I've sent updated patches based on the last feedback. Should I send a
> new one with the aliases, and if so, should the portage checks use the
> alias or real function?

Considering Michał's plan to expose these functions to QA checks in
repositories, it would make sense to go ahead and add expose the aliases
in misc-functions.sh now. On the other hand, it makes sense to use the
prefixed versions in all internal portage code, for consistency. So, I'd
probably just wait until later to add the unprefixed versions. I don't
have a strong opinion though. The new patch set that you posted looks
good to me.

> Just let me know what to change. I have no opinion what goes where. :-)
-- 
Thanks,
Zac