From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 531F41387D3 for ; Sat, 25 Oct 2014 20:16:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B0CF3E0959; Sat, 25 Oct 2014 20:16:01 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3C727E0951 for ; Sat, 25 Oct 2014 20:16:01 +0000 (UTC) Received: from [192.168.1.7] (ip70-181-96-121.oc.oc.cox.net [70.181.96.121]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id CBAAC3404BF; Sat, 25 Oct 2014 20:15:59 +0000 (UTC) Message-ID: <544C04FD.8010904@gentoo.org> Date: Sat, 25 Oct 2014 13:15:57 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: Michael Palimaka , gentoo-portage-dev@lists.gentoo.org Subject: [gentoo-portage-dev] Re: [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions. References: <1414253761-6310-1-git-send-email-kensington@gentoo.org> <544BFFAB.3000608@gentoo.org> <544C000A.6000002@gentoo.org> <544C0147.20300@gentoo.org> <544C0472.1030409@gentoo.org> In-Reply-To: <544C0472.1030409@gentoo.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: 0cc093a2-a546-45f1-b120-c3639bb88400 X-Archives-Hash: 495de4992409746f481ecd0bae94f42b On 10/25/2014 01:13 PM, Michael Palimaka wrote: > On 26/10/14 07:00, Zac Medico wrote: >>>> >>>> These functions are internals, so they need to be prefixed with __ like >>>> __eqalog and __eqawarnlog. >>>> >>> >>> Also, please unset them inside bin/save-ebuild-env.sh. >>> >> >> Actually, these suggestions are optional, since the environment from >> misc-functions.sh is never saved. However, if you wanted to move them to >> isolated-functions.sh, then these suggestions are mandatory. >> > > Is it better to move them to isolated-functions and implement the above > changes then? I only put it in misc-functions since it's near > install_qa_check and I'm not too familiar with the file layout. :-) Yes, I think so, since eventually you'll probably want to call them elsewhere. -- Thanks, Zac