From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 14CDE1387D3 for ; Sat, 25 Oct 2014 20:03:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AAAE0E0B82; Sat, 25 Oct 2014 20:00:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 399B7E0921 for ; Sat, 25 Oct 2014 20:00:14 +0000 (UTC) Received: from [192.168.1.7] (ip70-181-96-121.oc.oc.cox.net [70.181.96.121]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 07CDA340455; Sat, 25 Oct 2014 20:00:11 +0000 (UTC) Message-ID: <544C0147.20300@gentoo.org> Date: Sat, 25 Oct 2014 13:00:07 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org CC: Michael Palimaka Subject: Re: [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions. References: <1414253761-6310-1-git-send-email-kensington@gentoo.org> <544BFFAB.3000608@gentoo.org> <544C000A.6000002@gentoo.org> In-Reply-To: <544C000A.6000002@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 032f6f06-4079-45ef-89b5-b9024f77846c X-Archives-Hash: 354f8708d407be8081a3607dc6dc6799 On 10/25/2014 12:54 PM, Zac Medico wrote: > On 10/25/2014 12:53 PM, Zac Medico wrote: >> On 10/25/2014 09:15 AM, Michael Palimaka wrote: >>> +eqalog() { >>> + local tag=$1 x >>> + shift >>> + for x in "$@" ; do >>> + echo "${tag}" "${x}" >> "${T}"/qa.log >>> + done >>> +} >>> + >>> +eqawarnlog() { >>> + eqalog "$@" >>> + shift >>> + for x in "$@" ; do >>> + eqawarn " $x" >>> + done >>> +} >>> + >> >> These functions are internals, so they need to be prefixed with __ like >> __eqalog and __eqawarnlog. >> > > Also, please unset them inside bin/save-ebuild-env.sh. > Actually, these suggestions are optional, since the environment from misc-functions.sh is never saved. However, if you wanted to move them to isolated-functions.sh, then these suggestions are mandatory. -- Thanks, Zac