From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 95863138A2F for ; Sun, 17 Aug 2014 13:02:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 19EC0E0978; Sun, 17 Aug 2014 13:02:20 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A0AD1E095F for ; Sun, 17 Aug 2014 13:02:19 +0000 (UTC) Received: from [10.0.10.112] (unknown [195.254.219.2]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: bernalex) by smtp.gentoo.org (Postfix) with ESMTPSA id E4568340019 for ; Sun, 17 Aug 2014 13:02:17 +0000 (UTC) Message-ID: <53F0A7D5.9070609@gentoo.org> Date: Sun, 17 Aug 2014 15:02:13 +0200 From: Alexander Berntsen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] Output uniform status message before and after src_test() References: <1408227736-14310-1-git-send-email-mgorny@gentoo.org> In-Reply-To: <1408227736-14310-1-git-send-email-mgorny@gentoo.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: d7e7b3d3-7013-44b3-b129-51ae15bc362c X-Archives-Hash: f24dd957d0e394d78b1e1394ba4a185e -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 17/08/14 00:22, Michał Górny wrote: > Before, the status message indicating src_test() run was output > only if the default EAPI implementation was used. If an ebuild > overrode test phase, the test phase output lacked delimitation. > Instead, output uniform status messages before and after running > src_test() alike for other phase functions. Does this actually fix anything or matter to anyone? It looks fine to me, but seeing as there's no bug, I'm not sure it's actually fixing anything. Also, for the commit message, remember what we talked about with active sentences. Write "Do Foo to solve Bar", rather than "Bar is a problem. Here is a lengthy paragraph about that with a fix, Foo, somewhere at the end -- hope you don't miss it!". - -- Alexander bernalex@gentoo.org https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlPwp9UACgkQRtClrXBQc7XT0QEAjSQuUGkU84YKxtkIC4b/qSIN Iek0NB1dN1QV9eV52bQA/3SSgT/WJPjqAt9kz1xa+mrDENaGcYLsKLpHdOhjqhTb =5r99 -----END PGP SIGNATURE-----