From: Alexander Berntsen <bernalex@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] Output uniform status message before and after src_test()
Date: Sun, 17 Aug 2014 15:02:13 +0200 [thread overview]
Message-ID: <53F0A7D5.9070609@gentoo.org> (raw)
In-Reply-To: <1408227736-14310-1-git-send-email-mgorny@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 17/08/14 00:22, Michał Górny wrote:
> Before, the status message indicating src_test() run was output
> only if the default EAPI implementation was used. If an ebuild
> overrode test phase, the test phase output lacked delimitation.
> Instead, output uniform status messages before and after running
> src_test() alike for other phase functions.
Does this actually fix anything or matter to anyone? It looks fine to
me, but seeing as there's no bug, I'm not sure it's actually fixing
anything.
Also, for the commit message, remember what we talked about with
active sentences. Write "Do Foo to solve Bar", rather than "Bar is a
problem. Here is a lengthy paragraph about that with a fix, Foo,
somewhere at the end -- hope you don't miss it!".
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlPwp9UACgkQRtClrXBQc7XT0QEAjSQuUGkU84YKxtkIC4b/qSIN
Iek0NB1dN1QV9eV52bQA/3SSgT/WJPjqAt9kz1xa+mrDENaGcYLsKLpHdOhjqhTb
=5r99
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-08-17 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 22:22 [gentoo-portage-dev] [PATCH] Output uniform status message before and after src_test() Michał Górny
2014-08-17 13:02 ` Alexander Berntsen [this message]
2014-09-12 7:16 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F0A7D5.9070609@gentoo.org \
--to=bernalex@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox