From: Alexander Berntsen <bernalex@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCHES] @changed-deps + missing slot check reposted for bernalex
Date: Wed, 13 Aug 2014 23:09:50 +0200 [thread overview]
Message-ID: <53EBD41E.7010603@gentoo.org> (raw)
In-Reply-To: <1407950435-2520-1-git-send-email-mgorny@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
These look good. ACK on 1 and 2 from me, but I would like Sebastian,
Arfrever, Brian, or someone else at least to look over them. These
patches are too "interesting" to be pushed after a single ACK.
For 3, I think it looks nice but you should check with Brian & Tom
about whether to put it in now or in the refactor branch. Also, please
ask QA about it so we don't get another bikeshed marathon to deal with.
Lastly, I think the commit message of the first commit is very poorly
worded, but we've discussed that on IRC. Ping me there for more
details if you want.
Thanks for doing this!
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlPr1B4ACgkQRtClrXBQc7VG7gEAllXiY0FUKn+5dUajk/tiZoj/
3H3KW9MPfmfeMh0Dnv8BAJX+y8hsBnppm9W+ap8VfzkrxGeme6J6VSAdYCQd+Dea
=VX87
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-08-13 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 17:20 [gentoo-portage-dev] [PATCHES] @changed-deps + missing slot check reposted for bernalex Michał Górny
2014-08-13 17:20 ` [gentoo-portage-dev] [PATCH 1/3] vardb: Do not remove := from vdb on unmatched dependencies Michał Górny
2014-08-13 17:20 ` [gentoo-portage-dev] [PATCH 2/3] sets: Introduce @changed-deps to update packages which need dep changes Michał Górny
2014-08-13 17:20 ` [gentoo-portage-dev] [PATCH 3/3] repoman: Add check for missing slot values/slot operators Michał Górny
2014-08-13 21:09 ` Alexander Berntsen [this message]
2014-08-14 6:58 ` [gentoo-portage-dev] [PATCHES] @changed-deps + missing slot check reposted for bernalex Brian Dolbec
2014-08-27 20:53 ` Brian Dolbec
2014-08-28 9:00 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EBD41E.7010603@gentoo.org \
--to=bernalex@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox