From: Alexander Berntsen <bernalex@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH 0/4] Autounmask changes
Date: Wed, 13 Aug 2014 18:56:28 +0200 [thread overview]
Message-ID: <53EB98BC.4050404@gentoo.org> (raw)
In-Reply-To: <20140813094532.6ba40f8f.dolsen@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 13/08/14 18:45, Brian Dolbec wrote:
> Actually, re-reading your patches again, your patches actually made
> more sense to me finally. You were fixing it to make implied
> behavior the actual behavior. So while I was originally objecting
> to them, then was not opposing them (last time we discussed
> inclusion), I now see them much clearer and agree with them.
>
> The --ask implying --autounmask-write is something people would not
> object to so strongly like they did to your original patchset.
Let's merge the bug fix (see the other thread) first. I can still
prepare the other patches if you think that's worthwhile, but I prefer
keeping them separated from that very simple bugfix patch.
One thing that needs discussion is what to do with the current
behaviour of --autounmask, i.e. printing the suggestions. One thing
that was really weird in my original patches (the ones in this thread)
is this:
emerge foo # this will do what --autounmask does today
emerge foo --autounmask # this will do what --autounmask-write does
emerge foo -a # this will do what --ask --autounmask-write does
emerge foo --autounmask=n # this will do what --autounmask=n does
The problem here is that there is no way to do e.g. emerge foo --ask,
and get suggestions any longer. You can either have it prompt to write
stuff, or you can have it not do anything -- but you can't explicitly
have it suggest stuff without prompting to write. This is bad design.
So either I need to implement tri-state (--autounmask can be yes, no,
suggest), or I need to do something more drastic.
Suggestions welcome.
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlPrmLwACgkQRtClrXBQc7UBaQEAmdDIIApMb99GIM2UnPHmH6c2
IvuVynLLfbprR2WjdnEA/0czubzAIeGJPCbhQvEoHyb2BC3KSzWThaQVYFrvt05D
=5lOp
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-08-13 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 9:37 [gentoo-portage-dev] [PATCH 0/4] Autounmask changes Alexander Berntsen
2014-08-12 9:37 ` [gentoo-portage-dev] [PATCH 1/4] emerge: Deprecate --autounmask Alexander Berntsen
2014-08-12 9:37 ` [gentoo-portage-dev] [PATCH 2/4] emerge: Rename --autounmask-write to --autounmask Alexander Berntsen
2014-08-12 9:37 ` [gentoo-portage-dev] [PATCH 3/4] emerge: Make --autounmask=y if --ask=y Alexander Berntsen
2014-08-12 9:37 ` [gentoo-portage-dev] [PATCH 4/4] emerge: Let --autounmask=n override other options Alexander Berntsen
2014-08-13 16:06 ` [gentoo-portage-dev] [PATCH 0/4] Autounmask changes Alexander Berntsen
2014-08-13 16:45 ` Brian Dolbec
2014-08-13 16:56 ` Alexander Berntsen [this message]
2014-08-13 17:59 ` [gentoo-portage-dev] " Duncan
2014-08-13 18:39 ` Alexander Berntsen
2014-08-13 19:24 ` Wyatt Epp
2014-08-13 19:39 ` Alexander Berntsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EB98BC.4050404@gentoo.org \
--to=bernalex@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox