public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] Always warn about unknown mirrors (bug 501352)
@ 2014-02-15 12:40 Sebastian Luther
  2014-02-17  7:43 ` Mike Frysinger
  2014-02-17 16:21 ` Brian Dolbec
  0 siblings, 2 replies; 4+ messages in thread
From: Sebastian Luther @ 2014-02-15 12:40 UTC (permalink / raw
  To: gentoo-portage-dev

---
 pym/portage/package/ebuild/fetch.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pym/portage/package/ebuild/fetch.py b/pym/portage/package/ebuild/fetch.py
index 5316f03..5984d82 100644
--- a/pym/portage/package/ebuild/fetch.py
+++ b/pym/portage/package/ebuild/fetch.py
@@ -445,8 +445,9 @@ def fetch(myuris, mysettings, listonly=0, fetchonly=0,
 					filedict[myfile].extend(uris)
 					thirdpartymirror_uris.setdefault(myfile, []).extend(uris)
 
-				if not filedict[myfile]:
-					writemsg(_("No known mirror by the name: %s\n") % (mirrorname))
+				if mirrorname not in custommirrors and \
+					mirrorname not in thirdpartymirrors:
+					writemsg(_("!!! No known mirror by the name: %s\n") % (mirrorname))
 			else:
 				writemsg(_("Invalid mirror definition in SRC_URI:\n"), noiselevel=-1)
 				writemsg("  %s\n" % (myuri), noiselevel=-1)
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] Always warn about unknown mirrors (bug 501352)
  2014-02-15 12:40 [gentoo-portage-dev] [PATCH] Always warn about unknown mirrors (bug 501352) Sebastian Luther
@ 2014-02-17  7:43 ` Mike Frysinger
  2014-02-17 16:21 ` Brian Dolbec
  1 sibling, 0 replies; 4+ messages in thread
From: Mike Frysinger @ 2014-02-17  7:43 UTC (permalink / raw
  To: gentoo-portage-dev

[-- Attachment #1: Type: text/plain, Size: 11 bytes --]

lgtm
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] Always warn about unknown mirrors (bug 501352)
  2014-02-15 12:40 [gentoo-portage-dev] [PATCH] Always warn about unknown mirrors (bug 501352) Sebastian Luther
  2014-02-17  7:43 ` Mike Frysinger
@ 2014-02-17 16:21 ` Brian Dolbec
  2014-02-17 20:37   ` Sebastian Luther
  1 sibling, 1 reply; 4+ messages in thread
From: Brian Dolbec @ 2014-02-17 16:21 UTC (permalink / raw
  To: gentoo-portage-dev

On Sat, 15 Feb 2014 13:40:23 +0100
Sebastian Luther <SebastianLuther@gmx.de> wrote:

> ---
>  pym/portage/package/ebuild/fetch.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Yeah, looks fine. Merge it :)

Sorry for the delay reviewing.


-- 
Brian Dolbec <dolsen>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] Always warn about unknown mirrors (bug 501352)
  2014-02-17 16:21 ` Brian Dolbec
@ 2014-02-17 20:37   ` Sebastian Luther
  0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Luther @ 2014-02-17 20:37 UTC (permalink / raw
  To: gentoo-portage-dev

Am 17.02.2014 17:21, schrieb Brian Dolbec:
> On Sat, 15 Feb 2014 13:40:23 +0100
> Sebastian Luther <SebastianLuther@gmx.de> wrote:
> 
>> ---
>>  pym/portage/package/ebuild/fetch.py | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
> 
> Yeah, looks fine. Merge it :)
> 
> Sorry for the delay reviewing.
> 
> 
committed


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-02-17 20:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-15 12:40 [gentoo-portage-dev] [PATCH] Always warn about unknown mirrors (bug 501352) Sebastian Luther
2014-02-17  7:43 ` Mike Frysinger
2014-02-17 16:21 ` Brian Dolbec
2014-02-17 20:37   ` Sebastian Luther

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox