From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8850A138247 for ; Wed, 15 Jan 2014 21:12:01 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 75D37E0BA8; Wed, 15 Jan 2014 21:12:00 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B4522E0BA7 for ; Wed, 15 Jan 2014 21:11:59 +0000 (UTC) Received: from [192.168.11.3] ([88.150.18.76]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LqiJO-1VPF7M0HLu-00eOLI for ; Wed, 15 Jan 2014 22:11:58 +0100 Message-ID: <52D6F99D.4010308@gmx.de> Date: Wed, 15 Jan 2014 22:11:57 +0100 From: Sebastian Luther User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131111 Thunderbird/17.0.9 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v3] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491. References: <1389819791-17726-1-git-send-email-creffett@gentoo.org> In-Reply-To: <1389819791-17726-1-git-send-email-creffett@gentoo.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:n+XlKxou75HA2fZguKksnLErKgusj2jqPAFLIfn87QDIfD3XqRL vlJQmUmQ1y+YbdiIJIhv3Q+dc95QrBnabE7DmYRrDWfEiudYIW1uyZVAI88Jalzb/idSDPb OAOKhyLoR0VJCCmdNwn2LQ/1UypFj+AOMSTtwjwdyi5DmYI8iUX7mazOX/3vhXxjCnVqOa9 6zHDJJSdj2cP/GHL4t29Q== X-Archives-Salt: 138cc530-ae70-4eea-98e2-615d600b1089 X-Archives-Hash: f8459c4a443f425e66a8321ad75f51b0 Am 15.01.2014 22:03, schrieb Chris Reffett: > + def check_eapi(self, eapi): > + return eapi in ('0', '1') > + Instead of hard coding EAPIs here, you should use the functions in portage.eapi like eapi_has_src_prepare_and_src_configure(). Same applies for the later part of the patch. The class names of the checks have the same issue. I understand that there are existing checks with such names, but that doesn't mean that's a good idea to keep using them. You could name them after the phases you're checking for. Sebastian